fix: Test Compatibility returns true when schema missing #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
approved these changes
Nov 13, 2024
|
@enismustafaj please rebase? |
@jjaakola-aiven Thank you for having a look. Just rebased. |
|
@jjaakola-aiven any update on this??? |
To make the api compatible with Confluent Schema Registry, testing the schema compatibility should return "true" wheneber the subject, schema or the version is missing
jjaakola-aiven
force-pushed
the
fix/return-compatible-when-schema-not-there
branch
from
e1dddac to
2b218d1
Compare
jjaakola-aiven
approved these changes
Nov 27, 2024
|
@enismustafaj Sorry, I got caught on other items that required full attention. I rebased the branch, auto-merge should do the magic now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the api compatible with Confluent Schema Registry, testing the schema compatibility should return "true" whenever the subject, schema or the version is missing
About this change - What it does
References: #479
Why this way
This provides the compatibility with Confluent Schema registry. So, for people switching from Confluent to Karapace it will be a smother transition.